Delay registering commerce_customer addressfield#43
Closed
aheathgr wants to merge 1 commit into
Closed
Conversation
Fixes backdrop-contrib#42 This is an issue with the timing of things! If we haven't already enabled addressfield when we enable commerce_customer, Backdrop tries to register field_commerce_customer_address.json from the config directory before the addressfield module has made the addressfield field type available. This results in an error that the addressfield module isn't available (which it isn't!). We need to delay the loading of the field config file until all modules are fully installed and field types are registered, and we can do that by moving it to a hook_update(). We need to move that config file into a subdirectory of config, which I'm not crazy about, but this works.
Collaborator
|
@aheathgr can you say more about why "We need to move that config file into a subdirectory of config"? I'm a bit confused by that part of this changeset. |
Member
|
There was some discussion in the issue itself: |
Contributor
|
This PR should be closed, as the issue was fixed in a different way. |
Contributor
Author
|
@elisseck I thought I had closed this - and yes, we're going to adjust this as per #42 (comment), just haven't had a chance to circle back yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
This is an issue with the timing of things! If we haven't already enabled addressfield when we enable commerce_customer, Backdrop tries to register field_commerce_customer_address.json from the config directory before the addressfield module has made the addressfield field type available. This results in an error that the addressfield module isn't available (which it isn't!).
We need to delay the loading of the field config file until all modules are fully installed and field types are registered, and we can do that by moving it to a hook_update().
We need to move that config file into a subdirectory of config, which I'm not crazy about, but this works.